Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/remove multiple components+targets #1016

Merged
merged 5 commits into from
Apr 2, 2017
Merged

Add/remove multiple components+targets #1016

merged 5 commits into from
Apr 2, 2017

Conversation

durka
Copy link
Contributor

@durka durka commented Mar 29, 2017 •
edited
Loading

Same as #986 but for components and targets. After this I don't see any more places to add .multiple(true).

cc #1005

@durka
Copy link
Contributor Author

durka commented Mar 30, 2017

Not sure what's going on with multi_host_smoke_test but I can reproduce locally, will figure it out.

@durka
Copy link
Contributor Author

durka commented Mar 30, 2017 •
edited
Loading

Another note is that all these loops exit on the first error. If you rustup component add x y and x doesn't exist (or is already installed, see #1009), it won't get to y. I'm not sure whether this is desired behavior.

@brson
Copy link
Contributor

brson commented Mar 31, 2017

Another note is that all these loops exit on the first error. If you rustup component add x y and x doesn't exist (or is already installed, see #1009), it won't get to y. I'm not sure whether this is desired behavior.

Seems ok for now when there are no dependencies between components that need to be maintained.

@durka durka force-pushed the component-multiple branch from d5fa628 to cea6164 Compare April 1, 2017 00:57
@durka
Copy link
Contributor Author

durka commented Apr 1, 2017

Should be fixed now. Not really sure what I'm doing in the mock manifest code.

@Diggsey
Copy link
Contributor

Diggsey commented Apr 1, 2017

@bors r+ Thanks!

@bors
Copy link
Contributor

bors commented Apr 1, 2017

📌 Commit cea6164 has been approved by Diggsey

@bors
Copy link
Contributor

bors commented Apr 1, 2017

⌛ Testing commit cea6164 with merge af52e4d...

bors added a commit that referenced this pull request Apr 1, 2017
@bors
Auto merge of #1016 - durka:component-multiple, r=Diggsey
af52e4d 
Add/remove multiple components+targets

Same as #986 but for components and targets. After this I don't see any more places to add `.multiple(true)`.

cc #1005
@bors
Copy link
Contributor

bors commented Apr 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Diggsey
Pushing af52e4d to master...

@bors bors merged commit cea6164 into rust-lang:master Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@durka @brson @Diggsey @bors