fixes prompt asking for msvc even though -y is provided

[pxdeu]

Fixes #916
no_prompt was simply not being checked

[Diggsey]

@pxdeu Thanks for the PR!

I think in this case, we should still perform the MSVC check, even when -y is passed, but in the event that it fails, just print a warning instead of prompting the user. What do you think?

[pxdeu]

Sounds like a good idea. I thought about it when working on the issue. I only decided against it, because it would either slightly change the meaning of the function do_msvc_check (to not include the prompt) or add parameters to it.

Looking at it again, not including the prompt seems to be more in line with the rest of the code and the function is not called elsewhere as far as I can tell.

I can provide a new commit.

[Diggsey]

LGTM @bors r+

[bors]

📌 Commit ef36a24 has been approved by Diggsey

[bors]

⌛ Testing commit ef36a24 with merge 88c7217...

[pxdeu]

I didn't notice MSVC_MESSAGE was windows only, because I built it on windows.
Glad you have a CI in place to catch things like that.

[Diggsey]

@bors r+

[bors]

📌 Commit b6f105c has been approved by Diggsey

[bors]

⌛ Testing commit b6f105c with merge b0d3242...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: Diggsey
Pushing b0d3242 to master...