Allow adding the host as a target. #1219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rustup target add` subcommand treated the current host as an argument differently from any other, issuing an `AddingRequiredComponent` error result. This made it difficult for scripts to ensure a consistent target set since one could not just say `rustup target add $target1 $target2` without first checking whether `$target1` or `$target2` happen to match the host triplet and filtering that target out. Instead, allow adding a required component and treat it like any other already-installed extension. This involves some extra effort to de-duplicate the list of components to avoid printing the 'up to date' message more than once.
|
@bors: r+ Looks good to me, and sorry for the delay! |
|
📌 Commit 9ee11f7 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 13, 2017
Allow adding the host as a target. The `rustup target add` subcommand treated the current host as an argument differently from any other, issuing an `AddingRequiredComponent` error result. This made it difficult for scripts to ensure a consistent target set since one could not just say `rustup target add $target1 $target2` without first checking whether `$target1` or `$target2` happen to match the host triplet and filtering that target out. Instead, allow adding a required component and treat it like any other already-installed extension. This involves some extra effort to de-duplicate the list of components to avoid printing the 'up to date' message more than once.
|
💔 Test failed - status-appveyor |
|
Failing a single test: |
|
☔ The latest upstream changes (presumably #1255) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing due to inactivity - please feel feel free to open a new PR if you wish to continue working on this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rustup target addsubcommand treated the current hostas an argument differently from any other, issuing an
AddingRequiredComponenterror result.This made it difficult for scripts to ensure a consistent target
set since one could not just say
rustup target add $target1 $target2without first checking whether
$target1or$target2happento match the host triplet and filtering that target out.
Instead, allow adding a required component and treat it like
any other already-installed extension. This involves some
extra effort to de-duplicate the list of components to avoid
printing the 'up to date' message more than once.