windows: detect architecture on website, update to matching arch (#1353) #1354
Conversation
|
Notably, this shouldn't be merged without a test of rustup itself yet, just first feedback & an initial CI check. |
|
This looks good to me, thanks! What sort of testing did you have in mind for this? |
|
@alexcrichton |
|
I can confirm that locally after building the i686-pc-windows-msvc version it switched to x86_64-pc-windows-msvc |
src/rustup-cli/self_update.rs
Outdated
| // and also works around if the website messed up the detection. | ||
| // If someone really wants to use another version, he still can enforce | ||
| // that using the environment variable RUSTUP_OVERRIDE_HOST_TRIPLE. | ||
| #[cfg(windows)] |
There was a problem hiding this comment.
This ended up causing a build warning on windows, could if cfg!(windows) be used instead?
…t-lang#1353) Updates on windows will now switch over to host appropriate versions, ensuring the best user experience (e.g. x86_64 builds on x64). The website can distinguish between Win64/Win32 builds now and a new platform can be introduced more easily.
|
@alexcrichton So good to go from my side. |
|
@bors: r+ |
|
📌 Commit 0068f09 has been approved by |
windows: detect architecture on website, update to matching arch (#1353) Updates on windows will now switch over to host appropriate versions, ensuring the best user experience (e.g. x86_64 builds on x64). The website can distinguish between Win64/Win32 builds now and a new platform can be introduced more easily. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
windows: detect architecture on website, update to matching arch (rust-lang#1353) Updates on windows will now switch over to host appropriate versions, ensuring the best user experience (e.g. x86_64 builds on x64). The website can distinguish between Win64/Win32 builds now and a new platform can be introduced more easily. r? @alexcrichton
Updates on windows will now switch over to host appropriate versions,
ensuring the best user experience (e.g. x86_64 builds on x64).
The website can distinguish between Win64/Win32 builds now and
a new platform can be introduced more easily.
r? @alexcrichton