Fallbacks to wget if curl not installed #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify 'rustup-init.sh' to support wget if curl not installed. This situation often happens on some linux distribution.
|
@titansnow I slightly modified your version to avoid duplication of |
|
Looks good 😄 |
|
Looks good to me. r? @alexcrichton |
|
@bors: r+ |
|
📌 Commit faa08bd has been approved by |
bors
added a commit
that referenced
this pull request
Mar 22, 2018
Fallbacks to wget if curl not installed Tested in ubuntu docker with 1. Both curl and wget installed 2. only wget installed 3. only curl installed Console output for wget looks like this : ```shell root@845dcc4ba103:/# wget -qO- https://raw.githubusercontent.com/thibaultdelor/rustup.rs/faa08bd786b7282500cc4162a2f428484c891130/rustup-init.sh | sh info: downloading installer --2018-03-08 06:54:27-- https://static.rust-lang.org/rustup/dist/x86_64-unknown-linux-gnu/rustup-init Resolving static.rust-lang.org (static.rust-lang.org)... 54.230.135.47, 54.230.135.132, 54.230.135.130, ... Connecting to static.rust-lang.org (static.rust-lang.org)|54.230.135.47|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 12984456 (12M) [application/x-sharedlib] Saving to: '/tmp/tmp.DQhaNqhC4q/rustup-init' /tmp/tmp.DQhaNqhC4q/rustu 100%[==================================>] 12.38M 11.0MB/s in 1.1s 2018-03-08 06:54:29 (11.0 MB/s) - '/tmp/tmp.DQhaNqhC4q/rustup-init' saved [12984456/12984456] Welcome to Rust! This will download and install the official compiler for the Rust programming language, and its package manager, Cargo. It will add the cargo, rustc, rustup and other commands to Cargo's bin directory, located at: /root/.cargo/bin This path will then be added to your PATH environment variable by modifying the profile file located at: /root/.profile You can uninstall at any time with rustup self uninstall and these changes will be reverted. Current installation options: default host triple: x86_64-unknown-linux-gnu default toolchain: stable modify PATH variable: yes 1) Proceed with installation (default) 2) Customize installation 3) Cancel installation ```
|
☀️ Test successful - status-appveyor, status-travis |
Closed
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Oct 12, 2023
Fallbacks to wget if curl not installed Tested in ubuntu docker with 1. Both curl and wget installed 2. only wget installed 3. only curl installed Console output for wget looks like this : ```shell root@845dcc4ba103:/# wget -qO- https://raw.githubusercontent.com/thibaultdelor/rustup.rs/ba8e1a8988c00a3f7a2e5ddc4b2a4959bc071b8c/rustup-init.sh | sh info: downloading installer --2018-03-08 06:54:27-- https://static.rust-lang.org/rustup/dist/x86_64-unknown-linux-gnu/rustup-init Resolving static.rust-lang.org (static.rust-lang.org)... 54.230.135.47, 54.230.135.132, 54.230.135.130, ... Connecting to static.rust-lang.org (static.rust-lang.org)|54.230.135.47|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 12984456 (12M) [application/x-sharedlib] Saving to: '/tmp/tmp.DQhaNqhC4q/rustup-init' /tmp/tmp.DQhaNqhC4q/rustu 100%[==================================>] 12.38M 11.0MB/s in 1.1s 2018-03-08 06:54:29 (11.0 MB/s) - '/tmp/tmp.DQhaNqhC4q/rustup-init' saved [12984456/12984456] Welcome to Rust! This will download and install the official compiler for the Rust programming language, and its package manager, Cargo. It will add the cargo, rustc, rustup and other commands to Cargo's bin directory, located at: /root/.cargo/bin This path will then be added to your PATH environment variable by modifying the profile file located at: /root/.profile You can uninstall at any time with rustup self uninstall and these changes will be reverted. Current installation options: default host triple: x86_64-unknown-linux-gnu default toolchain: stable modify PATH variable: yes 1) Proceed with installation (default) 2) Customize installation 3) Cancel installation ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in ubuntu docker with
Console output for wget looks like this :