allow non-utf8 arguments to proxies #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euclio
changed the title
kinnison
reviewed
Jan 6, 2019
There was a problem hiding this comment.
Other than being unsure what 'proxies' are in this context, I think this change looks sensible. Certainly preferable to a panic, though I worry if the user might be surprised if they enter a non-utf8 toolchain name and are then confused when instead of honouring it, it is silently ignored.
src/rustup-cli/proxy_mode.rs
Outdated
| } else { | ||
| None | ||
| } | ||
| }); |
There was a problem hiding this comment.
Could we do the .starts_with('+') before the .to_str() and issue an error if the user has specified a non-utf8 toolchain name?
There was a problem hiding this comment.
Added the check and two more tests.
|
This looks good, but I agree it would be better to warn the user rather than silently ignore it. |
euclio
force-pushed
the
non-utf8-args
branch
6 times, most recently
from
a46990f
to
deea97e
Compare
kinnison
approved these changes
Jan 12, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#56146.