self update after updating a specific toolchain #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me with green CI |
kinnison
approved these changes
Jan 10, 2019
There was a problem hiding this comment.
I'm pretty OK with this in general, though the amount of tests needing --no-self-update I wonder if it might be better to also have a RUSTUP_SUPPRESS_SELF_UPDATE type environment variable which we could set by default in most of the expect_ok() calls.
Nothing blocking a merge IMO though.
| ) | ||
| .arg( | ||
| Arg::with_name("no-self-update") | ||
| .help("Don't perform self update when running the `rustup` command") |
There was a problem hiding this comment.
should this be:
.help("Don't perform self update when running the `rustup install` command")perhaps?
| ) | ||
| .arg( | ||
| Arg::with_name("no-self-update") | ||
| .help("Don't perform self update when running the `rustup` command") |
There was a problem hiding this comment.
Ditto here but with
.help("Don't perform self update when running the `rustup toolchain install` command")perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton
This will make sure people who do
rustup update stablestill get a new rustup