Better error message for missing binary #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-line
commented
Jan 20, 2019
In-line
force-pushed
the
better-error-message
branch
from
04ed1ba
to
c687d65
Compare
|
@In-line It looks like you're getting close, but your reformatting would be better done in the same commit, could you please amend your change to one commit (and also remove the exeext stuff since it's not needed for the component name. If you do that I think you're golden. I like the error message change, but we'll need to wait for at least one more maintainer to take a look. |
|
@kinnison I'm going to finish this PR at the end of the week. Thanks for the feedback! |
In-line
force-pushed
the
better-error-message
branch
from
be6c35d
to
6625ed4
Compare
In-line
force-pushed
the
better-error-message
branch
from
6625ed4
to
2da31be
Compare
|
LGTM! |
dwijnand
approved these changes
Jan 30, 2019
|
Awesome, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I was annoyed, that simple copy-pasting from error message didn't work, so I tried to make better suggestion.