Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install some GitHub issue templates #1625

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Install some GitHub issue templates #1625

merged 1 commit into from
Feb 10, 2019

Conversation

dwijnand
Copy link
Member

I've had good experiences using issue templates, and these are derived from the ones established in the cargo repo. WDYT?

@dwijnand
Copy link
Member Author

WDYT @kinnison?

kinnison
kinnison suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all I like the idea of having some templates. It might be nice to have a PR template later too but this is an excellent start.

With the changes I have suggested, I'd have no problem giving a 👍

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
@dwijnand
Copy link
Member Author

Thanks, @kinnison. All done.

@dwijnand dwijnand mentioned this pull request Feb 2, 2019
Closed
kinnison
kinnison approved these changes Feb 3, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwijnand
Copy link
Member Author

dwijnand commented Feb 7, 2019

r? @nrc

@nrc nrc merged commit e83464f into rust-lang:master Feb 10, 2019
@nrc
Copy link
Member

nrc commented Feb 10, 2019

SGTM, thanks!

@dwijnand dwijnand deleted the issue-templates branch February 10, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc approved these changes

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwijnand @nrc @kinnison