Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When updating, show "removing old component" to avoid confusion #1639

Merged
merged 1 commit into from
Feb 11, 2019
Merged

When updating, show "removing old component" to avoid confusion #1639

merged 1 commit into from
Feb 11, 2019

Conversation

das-sein
Copy link
Contributor

@das-sein das-sein commented Feb 5, 2019 •
edited
Loading

Resolution for UX issue described by #1283

When components were uninstalled during an update previously, the message would be:

info: removing component '<component>'

This has been changed to reassure the user that only old versions are being uninstalled:

info: removing previous version of component '<component>'

kinnison
kinnison approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, it's neat and clean. 👍

@das-sein das-sein mentioned this pull request Feb 7, 2019
Closed
@nrc nrc merged commit 0f2dd35 into rust-lang:master Feb 11, 2019
@nrc
Copy link
Member

nrc commented Feb 11, 2019

nice!

@thedrow thedrow mentioned this pull request Sep 13, 2019
Closed
@BeniCheni BeniCheni mentioned this pull request Sep 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@das-sein @nrc @kinnison