Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the error more verbose #1682

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Make the error more verbose #1682

merged 1 commit into from
Mar 12, 2019

Conversation

Nodraak
Copy link
Contributor

@Nodraak Nodraak commented Mar 5, 2019

A small attempt to improve unclear errors. cf. #1617

I can branch/rebase/etc if this PR does not conform to Rust standards.

kinnison
kinnison reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only cause for this error is out-of-disk-space then LGTM, otherwise maybe needs a wording tweak.

src/rustup-dist/src/errors.rs Outdated Show resolved Hide resolved
@dwijnand dwijnand merged commit 598b3cf into rust-lang:master Mar 12, 2019
@bors bors mentioned this pull request Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nodraak @kinnison @dwijnand