Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for dumb terminal #1749

Merged
merged 2 commits into from
Apr 14, 2019
Merged

Add test for dumb terminal #1749

merged 2 commits into from
Apr 14, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Apr 10, 2019 •
edited
Loading

cc @kinnison

Do we need to use isatty crate instead of manual hand code? But looks like
its repo has been archived.

Test for #1747.

@bors
Copy link
Contributor

bors commented Apr 11, 2019

☔ The latest upstream changes (presumably #1748) made this pull request unmergeable. Please resolve the merge conflicts.

@tesuji tesuji changed the title [BLOCKED] Add test for dumb terminal Add test for dumb terminal Apr 11, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Apr 13, 2019

Rebased on master.

kinnison
kinnison approved these changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over-all it looks good to me. I'm making the leap that isatty works well on all our platforms but it seems likely.

@kinnison kinnison merged commit f92aac5 into rust-lang:master Apr 14, 2019
@tesuji tesuji deleted the dumbterm branch April 14, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesuji @bors @kinnison