Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2019 #1773

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Visual Studio 2019 #1773

merged 1 commit into from
Apr 19, 2019

Conversation

TjeuKayim
Copy link
Contributor

Update Visual C++ install instructions, to link to Visual Studio 2019.

See #1772

@TjeuKayim TjeuKayim force-pushed the visual-studio-2019 branch 2 times, most recently from a15699f to 9043a8b Compare April 17, 2019 19:01
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

However README.md probably still has bad links. Could you provide another commit on the PR to resolve any further bad links for VS installation?

@TjeuKayim
Copy link
Contributor Author

You are right @kinnison, the README does mention Visual Studio 2015.
So I also changed those occurrences.

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the README changes, this LGTM. Thank you!

@kinnison kinnison merged commit e2d6af0 into rust-lang:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants