Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate std::env import #1817

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Remove duplicate std::env import #1817

merged 1 commit into from
Apr 29, 2019

Conversation

onatm
Copy link
Contributor

@onatm onatm commented Apr 28, 2019

This PR removes a duplicate import of std::env from cli/self_update.

I saw the duplicate import warning while working on #1808 and decided to tackle it in another PR

kinnison
kinnison approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane to me, Thank you

@kinnison kinnison merged commit c02861b into rust-lang:master Apr 29, 2019
@onatm onatm deleted the remove-duplicate-import branch April 29, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onatm @kinnison