Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle update across missing nightlies #2002

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Sep 18, 2019

Fixes #2001.

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works where it did not previously. 👍

@kinnison
Copy link
Contributor

I've asked the tests to re-try

This check is necessary for tests and other misbehaving repos where the
currently installed nightly may suddenly turn out to no longer be a
viable install candidate (e.g., because a component was retroactively
removed).
@jonhoo
Copy link
Contributor Author

jonhoo commented Sep 18, 2019

I pushed a change now that limit the backtracking explicitly to the date of the currently installed nightly, or alternatively the date of the first manifest ever (though I don't think that case is ever hit).

@kinnison kinnison merged commit 6f93cdc into rust-lang:master Sep 18, 2019
@jonhoo jonhoo deleted the skip-missing branch September 18, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustup should also skip the day which is no release when updating nightly
2 participants