Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --toolchain option to rustup which #2030

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Support --toolchain option to rustup which #2030

merged 1 commit into from
Sep 30, 2019

Conversation

BeniCheni
Copy link
Contributor

Resolves #1489. Add --toolchain option to rustup which & test.

Local Test
→ rustup which --toolchain=stable rustc                    
/Users/bchen/.rustup/toolchains/stable-x86_64-apple-darwin/bin/rustc

→ rustup --toolchain=nightly-2019-09-25-x86_64-apple-darwin which cargo
/Users/bchen/.rustup/toolchains/nightly-x86_64-apple-darwin/bin/cargo

@BeniCheni BeniCheni mentioned this pull request Sep 30, 2019
Closed
@BeniCheni BeniCheni force-pushed the which-by-toolchain branch 2 times, most recently from b2f8140 to 7d6af38 Compare September 30, 2019 03:54
@BeniCheni
Support --toolchain option to rustup which
d0b5b8b 
Update code format by cargo fmt for cli-misc.rs

Test both windows and non-windows which() in cli-misc.rs
kinnison
kinnison approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you.

@kinnison kinnison merged commit 2ce2428 into rust-lang:master Sep 30, 2019
@BeniCheni BeniCheni deleted the which-by-toolchain branch September 30, 2019 11:19
@BeniCheni BeniCheni mentioned this pull request Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustup which doesn't accept + arguments
2 participants
@BeniCheni @kinnison