Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using bright colors #2083

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Stop using bright colors #2083

merged 1 commit into from
Oct 26, 2019

Conversation

carloabelli
Copy link
Contributor

Bright colors often display badly for those who are using colorschemes
that use unexpected bright colors such as solarized.

Additionally, many terminals automatically display bold text in bright
colors (unless this option is explicitly disabled) particularly if bold
text is not supported.

It should be left up to the user whether they want their bold text to be
displayed in bright colors.

This should also fix #433 (if it is still an issue).

Bright colors often display badly for those who are using colorschemes
that use unexpected bright colors such as solarized.

Additionally, many terminals automatically display bold text in bright
colors (unless this option is explicitly disabled) particularly if bold
text is not supported.

It should be left up to the user whether they want their bold text to be
displayed in bright colors.
@kinnison
Copy link
Contributor

Thank you for your contribution. Could you please provide a couple of screenshots so that I can evaluate the visual difference between before and after for this PR?

@carloabelli
Copy link
Contributor Author

carloabelli commented Oct 25, 2019

@kinnison

For example if I use my base-16 color scheme and choose not to display bold text in bright colors:

2019-10-25T13:39:53,466307325-04:00

Then when displaying bright red, the text is actually displayed in orange:

2019-10-25T12:49:20,746254730-04:00

This is even more problematic for bright green because the text is almost invisible.

This PR results in the following colors instead

2019-10-25T12:51:17,643914764-04:00

For those terminals that automatically display bold text in bright colors (in my experience most of them) this should have no effect.

@carloabelli
Copy link
Contributor Author

Here's an example for bright green text:

Before:
2019-10-25T21:43:32,538280024-04:00

After:
2019-10-25T21:53:13,359710339-04:00

@kinnison
Copy link
Contributor

I can see how it makes a significant difference to readability for you, and I've tested it on my "normal" terminal and it's not sufficiently adversely affected to cause issues. I'm okay with this as a general readability improvement commit.

@kinnison kinnison merged commit 38200a9 into rust-lang:master Oct 26, 2019
@carloabelli
Copy link
Contributor Author

Thanks!

@carloabelli carloabelli deleted the no-bright-colors branch October 26, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White fonts tough to read on a white terminal
2 participants