Warn if complete profile is used #2138
Conversation
There was a problem hiding this comment.
This is indeed the kind of change I was hoping for, so ❤️ for that.
There's a typo in two places which suggests a shared static string would be best.
Also, as @payload suggested, it'd be useful to see a test for this. So to verify the change to the toolchain installation step, we should check that warning is present in at least one test in cli-v2.rs.
One option is to add it to test_complete_profile_skips_missing_when_forced() though perhaps a small test just for this would be best.
In addition, at least one test in cli-inst-interactive.rs should check for the warning in the installation mode. One option would be in install_forces_and_skips_rls() and another would be to create a new test just for this.
I look forward to seeing your updated PR, and thank you again.
- A warning message will be printed if a toolchain is installed in the rustup and rustup-init binary - Add unit tests to test if the warning message appears in rustup mode and setup mode Add warning message if toolchain is installed with the complete profile Add unit tests for warning message - add unit tests to test if the warning message was printed - move the warning message string to src/cli/common.rs to centralize the string Change executable to rustup-init in test_warn_if_complete_profile_is_used Fix tests by changing the arguments to rustup-init -y --profile complete in test_warn_if_complete_profile Shorten check for the error message in test_warn_if_complete_profile_is_used
This change was requested in #2136.
Whenever a user downloads a toolchain with the complete profile,
a warn message will be printed.