config: get_default_host_triple() should use from_host_or_build() #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to resolve an issue where installing on x86_64 with the i686 installer would claim to want to install x86_64 and then install i686 instead, ensure that we match the obvious behaviour (install matching the host) by making the default for the config match that. Fixes: rust-lang#2179 Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
kinnison
force-pushed
the
installer-default-host-consistency
branch
from
51be2e6
to
a985815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve an issue where installing on x86_64 with the
i686 installer would claim to want to install x86_64 and then
install i686 instead, ensure that we match the obvious behaviour
(install matching the host) by making the default for the config
match that.
Fixes: #2179
At the time of writing the initial change, I'm not certain how we'd test this in CI, but I'll give that some thought.