Add ToolchainComponentsMissing error msg #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to add tests, but it seems there is a new update_from_dist in dist tests, I don't know how to mock test |
kinnison
suggested changes
Apr 12, 2021
There was a problem hiding this comment.
I'd suggest trying to test this more as an integration test like those in cli-misc or cli-v2.
There are setup options for those which provide a channel which is missing (for example) RLS. the default profile wants the RLS component, so it should be possible to put together a test which triggers this pathway.
Rustin170506
force-pushed
the
rustin-patch-msg
branch
from
e1f25af
to
562f18c
Compare
Rustin170506
force-pushed
the
rustin-patch-msg
branch
from
562f18c
to
764b5d9
Compare
|
@kinnison Added test. |
|
@kinnison ping~ Ready for review. |
kinnison
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2705