Prevent need to refetch for v1 manifests #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
When we're installing a toolchain via the override mechanism we try and ensure components requested are present. This is a no-op on v1 manifest installations but we still end up downloading and checking the update hash. This is unnecessary, so this change attempts to prevent this by detecting a V1 install and skipping the component check if so. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
|
@Nemo157 Assuming this goes CI-green could you try this patch? |
|
Nice, github doesn't let you download artifacts when not logged in, so I can't just download it on my headless server 😭. Will have to build it locally I guess to test. |
|
Tested and LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #2777 rustup is re-syncing (fetching the channel checksum) on each run pre-1.8 when overridden to do so.
This results in (a) slowdown and (b) confusion. This PR fixes that by guessing V1 installs since they're subtly different from v2 installs (ignoring the lack of manifest file which we try and self-heal on v2 installs so couldn't use as the indicator).
This should fix #2777