Bump recursion limit to 20 #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinite recursion will conveniently hit any limit, so will still be detected. But non-infinite cases can hit >5 without too much trouble when custom build scripts invoke cargo, or when custom toolchains themselves call into cargo (or both at the same time), so let's raise the bar slightly. See also https://discord.com/channels/442252698964721669/463480252723888159/859585370689896460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infinite recursion will conveniently hit any limit, so will still be
detected. But non-infinite cases can hit >5 without too much trouble
when custom build scripts invoke cargo, or when custom toolchains
themselves call into cargo (or both at the same time), so let's raise
the bar slightly.
See also https://discord.com/channels/442252698964721669/463480252723888159/859585370689896460