Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test for proxies #2962

Closed

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Mar 11, 2022

close #2739

  • Add smoke test for proxies
  • Gen the new workflows

Comment on lines 50 to 54
# rust-lldb --version
# rust-gdb -h
# rust-gdbgui -h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not running these ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because they have other dependencies and there are related issues that have not been resolved. So we can skip it for now.
cc: #2838 and rust-lang/rust#61282

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 force-pushed the rustin-patch-smoke-test branch from bfc9b83 to 7109d9b Compare March 13, 2022 03:57
@Rustin170506 Rustin170506 marked this pull request as ready for review March 13, 2022 04:00
@Rustin170506 Rustin170506 requested a review from kinnison March 13, 2022 04:04
@Rustin170506 Rustin170506 changed the title Add smoke test for proxy Add smoke test for proxies Mar 13, 2022
@rbtcollins
Copy link
Contributor

I'm quite curious why this smoke test is a bash script, only running in CI, and not a rust integration test running in our test suite.

I can see the value in something that explicitly inspects the expected set of proxies, makes sure they can all be invoked, and are all correct hardlinks to each other. I don't think we have that today.

But I see lots of technical debt in this particular testing approach and am not a fan.

@Rustin170506 Rustin170506 deleted the rustin-patch-smoke-test branch March 13, 2022 07:45
@Rustin170506
Copy link
Member Author

I can see the value in something that explicitly inspects the expected set of proxies, makes sure they can all be invoked, and are all correct hardlinks to each other. I don't think we have that today.

@rbtcollins Sounds good, can you provide some guidance? I'm trying to invoke the bin out of mock and it looks like it goes into recursion and then fails.

 let path = &config.cargodir.join(&format!("bin/{}{}", tool, EXE_SUFFIX));
 expect_component_executable(config, path.to_str().unwrap());
out.stderr (1 lines):
    error: the 'rustdoc' binary, normally provided by the 'rustc' component, is not applicable to the 'stable-x86_64-apple-darwin' toolchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing for proxying, including both TOOLS and DUP_TOOLS
3 participants