Add automatic resume flag when retrying download with curl #3089
Conversation
|
Sorry for being a bit slow to respond yesterday ended up being busy! I did some manual testing by kill switching my network with my VPN (adding a video below to show the behavior). I could look into adding an actual test case for this but I would probably need some guidance as I'm fairly new to rust and I wouldn't exactly be sure how to go about testing this properly |
rustup-init.sh
Outdated
| @@ -610,7 +610,8 @@ check_curl_for_retry_support() { | |||
| local _retry_supported="" | |||
| # "unspecified" is for arch, allows for possibility old OS using macports, homebrew, etc. | |||
| if check_help_for "notspecified" "curl" "--retry"; then | |||
| _retry_supported="--retry 3" | |||
| # "-C -" tells curl to automatically find where to resume the download when retrying. | |||
| _retry_supported="--retry 3 -C -" | |||
There was a problem hiding this comment.
Do we need to check the --continue-at flag support?
There was a problem hiding this comment.
I can take a look at adding that tomorrow just to make sure, I did check when it was added when I was adding it and it seems to have been supported since 1998 I think it was? But probably better safe than sorry so I'll try to add a check for the support tomorrow
Looks good. Thank you!
I don't think there's a way to test it in code, so manual testing is good enough. |
|
Sorry that it took a while again ended up being more busy than expected. Added the check to verify that |
darkkeh
force-pushed
the
curl-resume-support
branch
from
076cdca
to
fe4bec0
Compare
|
There we go, commits have been squashed! |
|
Thanks again! 💚 💙 💜 💛 ❤️ |
Should fix the resume issue that caused #2853 to be reopened.
Simply adds the resume flag
-Cand tells curl to automatically figure out where to resume the download with-.