Purge Fastly cache after release #3819
Conversation
When releasing a new version of rustup, we need to purge the cached version on Fastly. This is done by calling Fastly's API using curl and purging the surrogate key that is used for rustup.
|
@jdno Thank you! Since this commit cannot be tested (and is essentially used by t-infra exclusively), I entrust you with its correctness. |
|
@jdno One (newbie) question: is it possible to move this script to e.g. some repo that you directly control? After all, it's a bit weird to have something in our repo that we can't run 🤔 |
|
Thanks for the quick review! I'll ask @Mark-Simulacrum to have a look as well. Before we merge this it would be great to test it with |
Mark and I briefly discussed in Zulip that it would be good to replace this script with an automated release process, maybe similar to rust-lang/promote-release which runs on AWS CodeBuild and is deployed through rust-lang/simpleinfra. We can definitely have a more concrete discussion about how the release process can be automated/improved. 🙂 |
|
Agreed with @rami3l that it doesn't make much sense for us to review this. A more automated release process sounds good, I guess that's something someone from the infra team would implement? |
|
This is waiting for @Mark-Simulacrum's approval then. |
The Rustup release process has historically been a manual process that involved copying files from S3 to the local machine and back to S3. This introduced a high risk of human error. When modifications to the existing release script became necessary, the decision was made to automate the release process (see rust-lang#3819 for details). The documentation in the dev-guide has been updated to cover the new release process, which is fully automated to produce `beta` releases using GitHub Actions and the [promote-release] tooling. [promote-release]: https://github.com/rust-lang/promote-release
The Rustup release process has historically been a manual process that involved copying files from S3 to the local machine and back to S3. This introduced a high risk of human error. When modifications to the existing release script became necessary, the decision was made to automate the release process (see rust-lang#3819 for details). The documentation in the dev-guide has been updated to cover the new release process, which is fully automated to produce `beta` releases using GitHub Actions and the [promote-release] tooling. [promote-release]: https://github.com/rust-lang/promote-release
|
We've been discussing refactoring the release process in Zulip and on the draft implementation in promote-release. The outcome of that discussion is that we definitely want to reimplement the Python script as part of I've written a draft for that process in #3844. |
When releasing a new version of rustup, we need to purge the cached version on Fastly. This is done by calling Fastly's API using curl and purging the surrogate key that is used for rustup.
See rust-lang/simpleinfra#415 for more details.