Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove printfs from ~/.cargo/env #527

Merged
merged 1 commit into from
Jun 17, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove printfs from ~/.cargo/env
This printout can break non-interactive shells that use ssh to
pipe binary data through stdout, like rsync. Plus it gets a bit
noisy.

Closes #498
erickt committed Jun 11, 2016

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
commit ac08f4c0585b5f2c9729c6ffa7f190b0b2749d5a
4 changes: 1 addition & 3 deletions src/rustup-cli/self_update.rs
Original file line number Diff line number Diff line change
@@ -224,9 +224,7 @@ pub fn install(no_prompt: bool, verbose: bool,
if cfg!(unix) {
let ref env_file = try!(utils::cargo_home()).join("env");
let ref env_str = format!(
"{}\n\
printf \"PATH environment variable set.\\n\"
printf \"You're ready to Rust!\\n\\n\"",
"{}\n",
try!(shell_export_string()));
try!(utils::write_file("env", env_file, env_str));
}