Hacky checksum fail #562
Merged
Hacky checksum fail #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| match *manifest_dl_res.as_ref().unwrap_err().kind() { | ||
| // Checksum failed - issue warning to try again later | ||
| ErrorKind::ChecksumFailed{url: _, expected: _, calculated: _} => (download.notify_handler)(Notification::ManifestChecksumFailedHack), |
There was a problem hiding this comment.
Please replace these three wildcard field patterns with { .. }.
|
Looks good. Just that one nit to address in the verbose pattern. Thanks! |
|
Thanks, have made your suggested change. (I totally forgot I could pattern match like that :D ) |
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #524 (sort of...)
The implementation is also worryingly hacky.. Sorry. Please feel free to suggest a cleaner implementation if you see one.
Also it looks like I changed the formatting in places - if that is an issue let me know and I will correct it. Changes to
dist.rsbegin here