Handle active custom toolchain in "show" #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this perhaps need its own test? |
|
@inejge Yes, please do add a test. There should be some existing |
For an active custom toolchain, targets can't be listed because a custom toolchain doesn't support components. Normally, this error would terminate 'show', which is surprising, so we silently use an empty target list instead.
|
Thanks again @inejge ! Going to deploy this in just a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #599. This is more complicated than it seems, because
showtries to fetch all components of the active toolchain, and a custom toolchain a) doesn't have them, and b) doesn't even have an enforced name form. This set of patches enforces the custom- prefix for custom toolchains and adds the minimum necessary logic to handle them inshow. It also updates the README to note the new requirement.Edit: whoops, wrong approach. I think I'll force push the new commits, the original ones are pointless.