Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to MSVC on Windows #842

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Default to MSVC on Windows #842

merged 1 commit into from
Dec 12, 2016

Conversation

brson
Copy link
Contributor

@brson brson commented Dec 2, 2016

Instead of picking MSVC/GNU based on detection, just default to MSVC.
During install, if MSVC is not detected provide guidance.

This is more predictable and easier to explain.

r? @alexcrichton

@alexcrichton
Copy link
Member

r+ but looks like there's windows failures

@brson
Copy link
Contributor Author

brson commented Dec 11, 2016

Fixed.

@brson brson mentioned this pull request Dec 11, 2016
@brson
Copy link
Contributor Author

brson commented Dec 11, 2016

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Dec 11, 2016

📌 Commit 44323ac has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 11, 2016

⌛ Testing commit 44323ac with merge 238b1d7...

bors added a commit that referenced this pull request Dec 11, 2016
Default to MSVC on Windows

Instead of picking MSVC/GNU based on detection, just default to MSVC.
During install, if MSVC is not detected provide guidance.

This is more predictable and easier to explain.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Dec 12, 2016

💔 Test failed - status-travis

Instead of picking MSVC/GNU based on detection, just default to MSVC.
During install, if MSVC is not detected provide guidance.

This is more predictable and easier to explain.
@brson
Copy link
Contributor Author

brson commented Dec 12, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2016

📌 Commit f384d7b has been approved by brson

@bors
Copy link
Contributor

bors commented Dec 12, 2016

⌛ Testing commit f384d7b with merge 523c888...

bors added a commit that referenced this pull request Dec 12, 2016
Default to MSVC on Windows

Instead of picking MSVC/GNU based on detection, just default to MSVC.
During install, if MSVC is not detected provide guidance.

This is more predictable and easier to explain.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Dec 12, 2016

💔 Test failed - status-appveyor

@brson
Copy link
Contributor Author

brson commented Dec 12, 2016

@bors retry

bors added a commit that referenced this pull request Dec 12, 2016
Default to MSVC on Windows

Instead of picking MSVC/GNU based on detection, just default to MSVC.
During install, if MSVC is not detected provide guidance.

This is more predictable and easier to explain.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Dec 12, 2016

⌛ Testing commit f384d7b with merge 3e8f6c3...

@brson brson merged commit 858dd08 into rust-lang:master Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants