Don't set low speed limits for curl #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some country, the network might be very slow occasionally. Setting "low speed limit" and "low speed time" will make rustup fail nearly all the time. Removing the settings will make rustup work on the unstable networks. This fixed rust-lang#902 .
|
OK, let's give it a shot. Thanks! |
|
How about a new cli flag to handle these cases? If one gets below these limits in countries with good internet, there most certainly is something wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some country, the network might be very slow occasionally. Setting
"low speed limit" and "low speed time" will make rustup fail nearly all
the time. Removing the settings will make rustup work on the unstable
networks.
This fixed #902 .