Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from winapi to windows-rs by microsoft #70

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

sn99
Copy link
Contributor

@sn99 sn99 commented Aug 1, 2022

Move from winapi to windows_sys considering winapi is no longer actively maintained compared to windows-rs

  • Builds
  • Passes tests except the last one which it fails without making any changes either

@jyn514
Copy link
Member

jyn514 commented Aug 1, 2022

winapi is no longer actively maintained compared to windows-rs

I'm not aware of this being true? What makes you think it's unmaintained?

@sn99
Copy link
Contributor Author

sn99 commented Aug 1, 2022

@jyn514 I see two main reasons to shift to windows-rs:

  1. Winapi is no longer actively maintained (last commit was 9 months ago as of now and 2nd last around 2 years ago) compared to last commit to windows-rs as of 3 days ago.
  2. windows-rs is the official Rust crate for Windows by Microsoft and is supposed to be providing a natural and idiomatic way for Rust developers to call Windows APIs. Some crates like socket2 have already migrated to it.

@sn99 sn99 changed the title Migrate from winapi to windows_sys Migrate from winapi to windows-rs by microsoft Aug 4, 2022
@jyn514 jyn514 merged commit 4cf6130 into rust-lang:master Aug 24, 2022
@jyn514
Copy link
Member

jyn514 commented Aug 24, 2022

Thanks for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants