Create S3 bucket for Rustup build artifacts #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new S3 bucket is being created as part of the effort to rebuild the Rustup release process. The bucket will store the build artifacts for Rustup, which the GitHub Actions in rust-lang/rustup will produce. Since the bucket is tied to a GitHub repository, only a single bucket in the production environment is being created.
|
I've created this as a draft PR, since applying it will overwrite the secrets in |
The current CI uploads Rustup build to the dev-static bucket. To not break the existing workflow while implementing the new release process, the current permissions are temporarily granted to the new user for Rustup's CI. They should be removed once the new release process has been implemented.
Mark-Simulacrum
approved these changes
Jun 21, 2024
terragrunt/modules/rustup/s3.tf
Outdated
| } | ||
|
|
||
| module "aws_iam_user" { | ||
| source = "../gha-iam-user" |
There was a problem hiding this comment.
We should really be using OIDC for anything new, not IAM users.
There was a problem hiding this comment.
Do we have a working configuration somewhere that we can either copy or extract into a module?
The new infrastructure for Rustup's build artifacts has been created. The Terragrunt configuration is not deployed from a locked Git commit, since only a single environment exists.
Mark-Simulacrum
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new S3 bucket is being created as part of the effort to rebuild the Rustup release process. The bucket will store the build artifacts for Rustup, which the GitHub Actions in rust-lang/rustup will produce.
Since the bucket is tied to a GitHub repository, only a single bucket in the production environment is being created.