Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for QNX Neutrino to master branch #380

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add support for QNX Neutrino to master branch #380

merged 1 commit into from
Jan 16, 2023

Conversation

flba-eb
Copy link
Contributor

@flba-eb flba-eb commented Jan 16, 2023

CC @gh-tr

@flba-eb flba-eb mentioned this pull request Jan 16, 2023
Closed
@flba-eb
Copy link
Contributor Author

flba-eb commented Jan 16, 2023

Clippy issues should vanish with #365.

Thomasdezeeuw
Thomasdezeeuw approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Any way to setup CI? Even running cargo check is good enough.

@flba-eb
Copy link
Contributor Author

flba-eb commented Jan 16, 2023

LGTM.

Any way to setup CI? Even running cargo check is good enough.

I'm afraid this is not yet possible because of the missing standard library: rust-lang/rust#106673
This will take some months to arrive in stable.

@Thomasdezeeuw
Copy link
Collaborator

I'm afraid this is not yet possible because of the missing standard library: rust-lang/rust#106673 This will take some months to arrive in stable.

We used have Redox on a nightly-only CI, so if that's possible it's fine to. In the mean time I'll merge this.

@Thomasdezeeuw Thomasdezeeuw merged commit 5b68514 into rust-lang:master Jan 16, 2023
@flba-eb
Copy link
Contributor Author

flba-eb commented Jan 17, 2023

Thank you very much, @Thomasdezeeuw . I would appreciate if you would also merge it to the 0.4 branch.

@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Jan 17, 2023
Merged
@Thomasdezeeuw
Copy link
Collaborator

Done in #382.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flba-eb @Thomasdezeeuw