Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNU/Hurd support #474

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add GNU/Hurd support #474

merged 1 commit into from
Nov 6, 2023

Conversation

sthibaul
Copy link
Contributor

No description provided.

@Thomasdezeeuw
Copy link
Collaborator

Can we add some CI support for this? Running cargo test or cargo check?

@sthibaul
Copy link
Contributor Author

(a CI would need to wait for rust-lang/libc#3325)

@sthibaul
Copy link
Contributor Author

sthibaul commented Oct 7, 2023

Mmm, but AIUI, the current CI infrastructure installs support for the target from rustup? This is a tier3, so IIUC we won't have this?

@Thomasdezeeuw
Copy link
Collaborator

Mmm, but AIUI, the current CI infrastructure installs support for the target from rustup? This is a tier3, so IIUC we won't have this?

Maybe once #465 is merged we can add it to the tier 3 check, see https://github.com/rust-lang/socket2/pull/465/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R68.

@sthibaul sthibaul force-pushed the master branch 2 times, most recently from e1c1345 to b716bc4 Compare October 9, 2023 18:26
@sthibaul
Copy link
Contributor Author

sthibaul commented Oct 9, 2023

Ah, that'll have to wait for rust-lang/rust#116527 apparently

@Thomasdezeeuw
Copy link
Collaborator

Since rust-lang/rust#116527 is merged, let's wait two days and restart the CI.

@sthibaul
Copy link
Contributor Author

Uh, between my tests and now, the use of msg_iov was added, and now I realize that the type was incorrect in libc, thus have to fix it there, and wait for another cycle.

@sthibaul sthibaul force-pushed the master branch 2 times, most recently from d32060f to 6e742df Compare November 5, 2023 19:25
@sthibaul
Copy link
Contributor Author

sthibaul commented Nov 5, 2023

Ok, there it is, now it's passing :D

@Thomasdezeeuw Thomasdezeeuw merged commit 3beceb2 into rust-lang:master Nov 6, 2023
41 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @sthibaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants