Make dedup guard optional #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
hkratz
force-pushed
the
disable_merge_functions_and_dedup_guard
branch
4 times, most recently
from
dbeaa5c to
301c8e0
Compare
This change also unconditionally enables `-D warnings`.
- vreinterpret* do not emit any instructions on arm. - vst1* intrinsics actual emit vst1.* instructions. - arm vext_s64/vext_u64 don't cause any instructions to be emitted.
hkratz
force-pushed
the
disable_merge_functions_and_dedup_guard
branch
from
301c8e0 to
19a920f
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2021
Update stdarch submodule This is mainly to fix the critical issue of aarch64 store intrinsics overwriting additional memory, see rust-lang/stdarch#1220 Changes: * aarch64/armv7: additional vld1/vst1 intrinsics + perf fixes for existing ones * rust-lang/stdarch#1205 * rust-lang/stdarch#1207 * rust-lang/stdarch#1216 * armv7: Make FMA work with vfpv4 and optimize * rust-lang/stdarch#1219 * Non-visible changes to the testing framework * rust-lang/stdarch#1208 * rust-lang/stdarch#1211 * rust-lang/stdarch#1213 * rust-lang/stdarch#1215 * rust-lang/stdarch#1218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dedup guard creates additional instructions in the test shims which cause various problems with testing intrinsics such as inadvertedly checking for dedup guard instructions, not useful instructions counts and inadvertedly crossing the inlining threshold.
This PR disables the dedup guard if the environment variable
STDARCH_DISABLE_DEDUP_GUARDis set. It only works properly if the LLVM MergeFunctions pass is disabled, e.g. with-Z merge-functions=disabledinRUSTFLAGS.It also disables the dedup guard for the
ci/run.shTODO: