Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the asm macro in std_detect #1290

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Mar 9, 2022

Fixes #1289

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@MikaelUrankar
Copy link
Contributor

It fails:

  --> library/stdarch/crates/std_detect/src/detect/os/aarch64.rs:19:12                                                                                                                                                                                        
   |                                                                                                                                                                                                                                                          
19 | use crate::arch::asm;                                                                                                                                                                                                                                       |            ^^^^                                                                                                                                                                                                                                          
   |            |                                                                                                                                                                                                                                             
   |            unresolved import                                                                                                                                                                                                                             
   |            help: a similar path exists: `core::arch`  

@lu-zero
Copy link
Contributor Author

lu-zero commented Mar 9, 2022 via email

@bjorn3
Copy link
Member

bjorn3 commented Mar 9, 2022

This should use use core::arch::asm; instead of use crate::arch::asm;, right?.

@MikaelUrankar
Copy link
Contributor

MikaelUrankar commented Mar 9, 2022

This should use use core::arch::asm; instead of use crate::arch::asm;, right?.

This is was I tested yesterday and it builds fine:
#1289 (comment)

@MikaelUrankar
Copy link
Contributor

how do you build it?

On Wed, Mar 9, 2022, 18:16 MikaelUrankar @.> wrote: It fails: --> library/stdarch/crates/std_detect/src/detect/os/aarch64.rs:19:12 | 19 | use crate::arch::asm; | ^^^^ | | | unresolved import | help: a similar path exists: core::arch — Reply to this email directly, view it on GitHub <#1290 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2LJCLOPN5WB4Q7EJF3OLU7DMHVANCNFSM5QJYSIXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.>

Using the FreeBSD ports infrastructure on native hardware (honeycomb)

@Amanieu Amanieu merged commit 8e09c37 into rust-lang:master Mar 11, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2022
Update stdarch

library/stdarch bcbe010...d215afe (7):
  - Add the rdm target feature to the sqrdmlsh intrinsic. (rust-lang/stdarch#1285)
  - Remove use of `#[rustc_deprecated]`
  - Remove feature gates for stabilized features
  - Change remaining _undefined_ functions to zero-init
  - Use SPDX license format and update packed_simd crate link (rust-lang/stdarch#1297)
  - Fix broken links (rust-lang/stdarch#1294)
  - Import the asm macro in std_detect (rust-lang/stdarch#1290)
workingjubilee pushed a commit to tcdi/postgrestd that referenced this pull request Sep 15, 2022
Update stdarch

library/stdarch bcbe0106...d215afe9 (7):
  - Add the rdm target feature to the sqrdmlsh intrinsic. (rust-lang/stdarch#1285)
  - Remove use of `#[rustc_deprecated]`
  - Remove feature gates for stabilized features
  - Change remaining _undefined_ functions to zero-init
  - Use SPDX license format and update packed_simd crate link (rust-lang/stdarch#1297)
  - Fix broken links (rust-lang/stdarch#1294)
  - Import the asm macro in std_detect (rust-lang/stdarch#1290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could not compile std_detect on FreeBSD aarch64 rust 1.59.0
5 participants