[wasm32] Add an intrinsic for the throw instruction #1542
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks. |
coolreader18
force-pushed
the
wasm32-throw
branch
from
78126eb
to
97a51c0
Compare
Ohh. Fair. I guess the other PR has to come first. |
coolreader18
force-pushed
the
wasm32-throw
branch
from
97a51c0
to
e6c391a
Compare
|
Ah. The test is failing because wasmtime doesn't have exception support yet :/ |
|
I guess I missed that testing locally, somehow. Could run it in nodejs, I guess? Not really sure. |
|
@Amanieu what are your thoughts on just not having a |
|
That's probably fine for now, but should be addressed as soon as it can be tested in CI. |
|
LGTM, now you just need to create a tracking issue in rust-lang/rust for this feature. |
|
I was thinking of having it just be perma-unstable for the foreseeable future - the llvm intrinsic is likely to change, and I don't see it being super useful at least until panic=unwind via exception-handling is stable (+ llvm support for non-cpp exception tags). Atm it's more of just an implementation detail for libpanic_unwind to use. Maybe that doesn't discount that it should have a tracking issue, but idk. |
|
Eh whatever, I'll make an issue. |
coolreader18
force-pushed
the
wasm32-throw
branch
2 times, most recently
from
c70fe9b
to
a1dfb7a
Compare
… r=bjorn3 Use throw intrinsic from stdarch in wasm libunwind Tracking issue: rust-lang#118168 This is a very belated followup to rust-lang#121438; now that rust-lang/stdarch#1542 is merged, we can use the intrinsic exported from `core::arch` instead of defining it inline. I also cleaned up the cfgs a bit and added a more detailed comment.
… r=bjorn3 Use throw intrinsic from stdarch in wasm libunwind Tracking issue: rust-lang#118168 This is a very belated followup to rust-lang#121438; now that rust-lang/stdarch#1542 is merged, we can use the intrinsic exported from `core::arch` instead of defining it inline. I also cleaned up the cfgs a bit and added a more detailed comment.
Rollup merge of rust-lang#131418 - coolreader18:wasm-exc-use-stdarch, r=bjorn3 Use throw intrinsic from stdarch in wasm libunwind Tracking issue: rust-lang#118168 This is a very belated followup to rust-lang#121438; now that rust-lang/stdarch#1542 is merged, we can use the intrinsic exported from `core::arch` instead of defining it inline. I also cleaned up the cfgs a bit and added a more detailed comment.
Use throw intrinsic from stdarch in wasm libunwind Tracking issue: #118168 This is a very belated followup to #121438; now that rust-lang/stdarch#1542 is merged, we can use the intrinsic exported from `core::arch` instead of defining it inline. I also cleaned up the cfgs a bit and added a more detailed comment.
For use in rust-lang/rust#121438. I was conservative in the wording of the docs cause I feel like this is the right place to put the intrinsic, but it likely won't be stabilized (at least in its current state).