Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove has_cpuid #1595

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Remove has_cpuid #1595

merged 1 commit into from
Jun 29, 2024

Conversation

workingjubilee
Copy link
Member

Implements the resolution of rust-lang/rust#60123

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@workingjubilee
Copy link
Member Author

The FCP isn't over yet but I figured I might as well while I was looking at stdarch for other reasons.

@workingjubilee
Copy link
Member Author

The FCP is over.

@Amanieu
Copy link
Member

Amanieu commented Jun 29, 2024

We still want to avoid executing the CPUID instruction on SGX targets.

@workingjubilee
Copy link
Member Author

so like that?

@Amanieu Amanieu force-pushed the remove-has-cpuid branch from f1aacbe to 105a74a Compare June 29, 2024 17:17
@Amanieu Amanieu enabled auto-merge (rebase) June 29, 2024 17:17
@Amanieu Amanieu merged commit bb74d8f into rust-lang:master Jun 29, 2024
30 checks passed
@workingjubilee workingjubilee deleted the remove-has-cpuid branch June 29, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants