cleanup wasm const fn #1660
Merged
cleanup wasm const fn #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
commented
Oct 26, 2024
|
Okay the try run here confirms that this will indeed work, so -- this should be good to go. :) |
|
Should we wait until the rustc fix lands for #1661 or is the allow still needed? |
|
That's an unrelated problem, it would pop up in any PR. Not sure if it should block this one.
The abi lint got backed out again anyway so it will be gone on the next nightly.
|
|
The new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't need these feature gates any more, that was just an attempt at a transition that didn't quite work out.