Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ADX-related intrinsics #631

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Add ADX-related intrinsics #631

merged 1 commit into from
Jan 7, 2019

Conversation

alexcrichton
Copy link
Member

Closes #322

gnzlbg
gnzlbg reviewed Jan 4, 2019
View reviewed changes
coresimd/x86/adx.rs Outdated Show resolved Hide resolved
@alexcrichton alexcrichton force-pushed the adx branch 2 times, most recently from aa0b548 to d865c17 Compare January 7, 2019 16:03
@alexcrichton alexcrichton merged commit d464018 into rust-lang:master Jan 7, 2019
@alexcrichton alexcrichton deleted the adx branch January 7, 2019 16:04
jethrogb
jethrogb reviewed Jan 31, 2019
View reviewed changes
coresimd/x86/adx.rs
/// the carry-out is returned (carry or overflow flag).
#[inline]
#[target_feature(enable = "adx")]
#[cfg_attr(test, assert_instr(adc))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, it should say adcx

Copy link
Contributor

@gnzlbg gnzlbg Jan 31, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jethrogb Could you submit a PR with that fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some work is involved in actually making it work that way, see #663

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened an issue so that we don't forget about this #666

@gnzlbg gnzlbg mentioned this pull request Jan 31, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethrogb jethrogb jethrogb left review comments

@gnzlbg gnzlbg gnzlbg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcrichton @gnzlbg @jethrogb