Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary parens. #839

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Remove unnecessary parens. #839

merged 1 commit into from
Jan 30, 2020

Conversation

Tyg13
Copy link
Contributor

@Tyg13 Tyg13 commented Jan 26, 2020

Remove unnecessary parens in const assigned value.

CC: rust-lang/rust#67942

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Behrouz-m
Copy link

Remove unnecessary parens in const assigned value.

CC: rust-lang/rust#67942

hi.
that issue is not related to this commit.

@Tyg13
Copy link
Contributor Author

Tyg13 commented Jan 26, 2020

Remove unnecessary parens in const assigned value.
CC: rust-lang/rust#67942

hi.
that issue is not related to this commit.

See this comment. These unnecessary parentheses are now linted against, and prevent a successful build of the parent repo.

@Behrouz-m
Copy link

Behrouz-m commented Jan 27, 2020

Remove unnecessary parens in const assigned value.
CC: rust-lang/rust#67942

hi.
that issue is not related to this commit.

See this comment. These unnecessary parentheses are now linted against, and prevent a successful build of the parent repo.

yes, it is correct. but why does your commit fail in the test phase? Were not those parens needed in that specific test?

@lu-zero
Copy link
Contributor

lu-zero commented Jan 27, 2020

macos was using the stable rustc due some situation with rustup. Now it should be fine if you rebase it.

@Tyg13
Copy link
Contributor Author

Tyg13 commented Jan 29, 2020

Should be all set for integration.

@alexcrichton alexcrichton merged commit dea5752 into rust-lang:master Jan 30, 2020
@alexcrichton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants