Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extending teams from other teams #1032

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

rylev
Copy link
Member

@rylev rylev commented Jul 19, 2023

This PR allows extending team membership by the membership of another team. Concretely this PR changes the following:

  • Team::members, Data::active_members, and Permissions::allowed_people now all return a Result since getting all members can fail if an included team does not exist.
  • Added Team::contains_person to test whether a team contains a person as a member
  • Made wg-leads a marker team instead of a working group
  • Created a project-group-leads marker team
  • Removed the use of the various special "include-*" options from all teams except for the special marker teams that those options exist for. All other teams that also want to include those members, can use included-teams instead.

And lastly, the entire point of this PR:

  • Made the inside-rust-reviewers include the leadership council

@Mark-Simulacrum
Copy link
Member

Hm, this seems good (looks like CI is failing). For the specific use case of council it probably makes sense to just grant write permissions in general on the repo rather than just inside rust.

But happy to approve once CI is fixed.

@rylev
Copy link
Member Author

rylev commented Jul 19, 2023

@Mark-Simulacrum done

@rylev rylev merged commit d51bab6 into rust-lang:master Jul 20, 2023
@rylev rylev deleted the allow-extending-teams branch July 20, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants