Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdarch repository under automation #1263

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 22, 2024

Repo: https://github.com/rust-lang/stdarch

The two old branch protections (see below) looked suspicious, so I removed them, and only kept master. The proposed branch protection requires PRs, but not PR approvals.

CC @Amanieu

Extracted from GH:

org = "rust-lang"
name = "stdarch"
description = "Rust's standard library vendor-specific APIs and run-time feature detection"
bots = []

[access.teams]
libs-contributors = "write"
security = "pull"
release = "write"
libs = "write"
bots = "write"
libs-api = "write"

[access.individuals]
joshtriplett = "write"
gnzlbg = "admin"
rust-highfive = "write"
Mark-Simulacrum = "admin"
rust-lang-owner = "admin"
rust-timer = "write"
workingjubilee = "write"
dtolnay = "write"
BurntSushi = "write"
Amanieu = "write"
m-ou-se = "write"
jdno = "admin"
rylev = "admin"
yaahc = "write"
bors = "write"
cuviper = "write"
ChrisDenton = "write"
JohnTitor = "write"
Dylan-DPC = "write"
SimonSapin = "write"
lu-zero = "write"
sunfishcode = "write"
kennytm = "write"
KodrAus = "write"
badboy = "admin"
rustbot = "write"
pietroalbini = "admin"
thomcc = "write"
cramertj = "write"
the8472 = "write"
tmandry = "write"

[[branch-protections]]
pattern = "master"
ci-checks = []
dismiss-stale-review = false
pr-required = false
review-required = false

[[branch-protections]]
pattern = "rust-1.28.0"
ci-checks = []
dismiss-stale-review = false
pr-required = false
review-required = false

[[branch-protections]]
pattern = "*do-not-delete*"
ci-checks = []
dismiss-stale-review = false
pr-required = false
review-required = false

@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2024

By the way there is an annoying setting on std where PRs can't be merged with a merge commit, it only allows squashing or rebasing. rust-lang/stdarch#1501

@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 22, 2024

We can't currently change that using automation (I think), so it might be easier to ask an admin to do this (CC @jdno ?).

@rylev rylev merged commit 58c7c11 into rust-lang:master Jan 23, 2024
1 check passed
@Kobzol Kobzol deleted the repo-stdarch branch January 23, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants