-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename macos
team to apple
, and add apple
Zulip group
#1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, I've added a few of your missing Zulip IDs to the repo, not sure whether I was supposed to do that or not |
madsmtm
changed the title
Rename
Rename Apr 19, 2024
macos
team to apple
, and add Zulip groupmacos
team to apple
, and add apple
Zulip group
This was referenced Apr 19, 2024
davidtwco
approved these changes
Apr 23, 2024
jackh726
approved these changes
Apr 28, 2024
I'm going to go ahead and merge this. It's a bit weird because we don't really have good rules or guidelines around marker groups like this and who has the privilege to "modify" them. That being said, I don't think there's any harm in doing this and we can also revert later. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 5, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 11, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
May 18, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 24, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed today on Zulip that it might make sense to expand the scope of this team to include the other Apple platforms, namely iOS, tvOS, watchOS and visionOS.
Pinging current members of the team; @hkratz, @inflation, @shepmaster, @thomcc, @nvzqz.
Are you fine with the expanded scope of the team, and being on the ping list for
@rustbot ping apple
?Additionally, I've introduced the
apple
Zulip ping group, does this make sense, and are you fine with being in that ping group? (if not, I'll add you to theexcluded-people
).(Note that this is not officially affiliated with Apple, it's just the name that makes the most sense).
I will make the corresponding PR to updateEDIT: Donetriagebot.toml
inrust-lang/rust
soon