Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename macos team to apple, and add apple Zulip group #1436

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Apr 19, 2024

We discussed today on Zulip that it might make sense to expand the scope of this team to include the other Apple platforms, namely iOS, tvOS, watchOS and visionOS.

Pinging current members of the team; @hkratz, @inflation, @shepmaster, @thomcc, @nvzqz.

Are you fine with the expanded scope of the team, and being on the ping list for @rustbot ping apple?

Additionally, I've introduced the apple Zulip ping group, does this make sense, and are you fine with being in that ping group? (if not, I'll add you to the excluded-people).

(Note that this is not officially affiliated with Apple, it's just the name that makes the most sense).


I will make the corresponding PR to update triagebot.toml in rust-lang/rust soon EDIT: Done

@madsmtm
Copy link
Contributor Author

madsmtm commented Apr 19, 2024

Also, I've added a few of your missing Zulip IDs to the repo, not sure whether I was supposed to do that or not

@madsmtm madsmtm changed the title Rename macos team to apple, and add Zulip group Rename macos team to apple, and add apple Zulip group Apr 19, 2024
@jackh726
Copy link
Member

I'm going to go ahead and merge this.

It's a bit weird because we don't really have good rules or guidelines around marker groups like this and who has the privilege to "modify" them.

That being said, I don't think there's any harm in doing this and we can also revert later.

@jackh726 jackh726 merged commit 6d2a520 into rust-lang:master Apr 28, 2024
1 check passed
@madsmtm madsmtm deleted the apple branch April 28, 2024 22:45
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2024
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
fmease added a commit to fmease/rust that referenced this pull request May 5, 2024
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2024
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 11, 2024
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request May 18, 2024
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 24, 2024
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants