-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a rustc_codegen_c
repository
#1486
Conversation
repos/rust-lang/rustc_codegen_c.toml
Outdated
[access.individuals] | ||
tgross35 = 'maintain' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a policy of not giving individual access anymore. Can you find a team that would be appropriate to add here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler makes sense (and is included). I'm just not a member of any relevant team but am the mentor for this project. Any suggestions?
Maybe I could join e.g. compiler contributors, but I have no clue what is required there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other suggestion I have is to create a subteam of compiler responsible for this backend. You might want to discuss with the compiler team.
I updated this to be both compiler and libs with contributors, which covers me. I think this is fine, if not then we might just need a new group. @wesleywiser can you confirm? |
Not sure that adding libs/libs-contributors here is the right choice. I think the most lightweight option is to make a marker team like "ospp-2024-codegen-c" to add both you and potentially the ospp participant? |
One of the OSPP projects this year is a C codegen backend. Create a repository where this will be developed, and a `codegen-c-maintainers` compiler subteam to maintain it.
Sorry @jackh726, I missed your comment. I changed this to create a subteam This is about the same as cg_gcc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to go ahead and merge this.
Am going to cc @wesleywiser and @davidtwco here - let me know if you have concerns
One of the OSPP projects this year is a C codegen backend. Create a repository where this will be developed, modeled off the codegen_cranelift repo file.
r? @Kobzol since I think you are in the loop with this