Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a rustc_codegen_c repository #1486

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

tgross35
Copy link
Contributor

One of the OSPP projects this year is a C codegen backend. Create a repository where this will be developed, modeled off the codegen_cranelift repo file.

r? @Kobzol since I think you are in the loop with this

Comment on lines 9 to 10
[access.individuals]
tgross35 = 'maintain'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a policy of not giving individual access anymore. Can you find a team that would be appropriate to add here instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler makes sense (and is included). I'm just not a member of any relevant team but am the mentor for this project. Any suggestions?

Maybe I could join e.g. compiler contributors, but I have no clue what is required there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other suggestion I have is to create a subteam of compiler responsible for this backend. You might want to discuss with the compiler team.

@tgross35
Copy link
Contributor Author

I updated this to be both compiler and libs with contributors, which covers me. I think this is fine, if not then we might just need a new group.

@wesleywiser can you confirm?

@jackh726
Copy link
Member

Not sure that adding libs/libs-contributors here is the right choice. I think the most lightweight option is to make a marker team like "ospp-2024-codegen-c" to add both you and potentially the ospp participant?

One of the OSPP projects this year is a C codegen backend. Create a
repository where this will be developed, and a `codegen-c-maintainers`
compiler subteam to maintain it.
@tgross35
Copy link
Contributor Author

Sorry @jackh726, I missed your comment. I changed this to create a subteam codegen-c-maintainers (opted against including OSPP-2024 since this project will outlive it) with Amanieu (OSPP organizer) and myself (advisor for this project) as members. This team and compiler can maintain, compiler-contributors has write.

This is about the same as cg_gcc.

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and merge this.

Am going to cc @wesleywiser and @davidtwco here - let me know if you have concerns

@jackh726 jackh726 merged commit 9927255 into rust-lang:master Aug 26, 2024
1 check passed
@tgross35 tgross35 deleted the cg-c branch August 26, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants