repos/rfcs: Remove approvals requirement #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFCs already go through the FCP flow where (almost) all team members need to check their approval checkbox. Requiring an additional GitHub-based PR approval seems like an unnecessary burden to get the RFC merged once the FCP period has concluded.
jackh726
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFCs already go through the FCP flow where (almost) all team members need to check their approval checkbox. Requiring an additional GitHub-based PR approval seems like an unnecessary burden to get the RFC merged once the FCP period has concluded.
This PR sets number of required GitHub-based approvals (back?) to zero, which AFAIU matches that value that had been used in the past for this repository.
Related: