glossary: define place, value, representation #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
value-place-repr
branch
from
fcafd6c to
3f3a8ab
Compare
RalfJung
commented
Jul 25, 2019
gnzlbg
reviewed
Jul 25, 2019
|
Looks good. I'm going to unsubscribe from this but feel free to ping me once this glossary entry is added and I'll do that other PR where all the entries are put in alphabetical order and wrapped to 80 columns. |
Centril
approved these changes
Jul 25, 2019
Closed
RalfJung
force-pushed
the
value-place-repr
branch
from
86f3ed5 to
78cad03
Compare
|
@ubsan I think you also have opinions on this. |
hanna-kruppe
approved these changes
Jul 27, 2019
RalfJung
force-pushed
the
value-place-repr
branch
from
dfbabc7 to
f0511a2
Compare
This was referenced Jul 31, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested during the meeting, moving this from #175 into its own PR.
I think I resolved the feedback I got, except for what I will now add again as comments here.
Cc @gnzlbg @Lokathor @rkruppe @Centril