This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Remove extension-side problem matchers to remove duplicate error/warnings #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings. The language server now directly posts diagnostics via LSP, so parsing the server output creates duplicate entries.
|
I don't think this is the correct fix for #133 - Although the RLS does supply some errors of its own, these problem matchers are for when the user runs the |
|
Agreed, it'd be good to keep them to be honest. It might be worth following vscode-go and deduplicating the diagnostics on the extension side. I'll close the PR but thank you regardless! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #133)
The language server now directly posts diagnostics via LSP, so the extension doesn't have to do parsing anymore; this was causing #133.