This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Add setting for clippy_preference #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy is an optional feature and we don't build it by default. To get Clippy you need to build the RLS yourself and enable the Clippy feature at compile time. This should change in the near future though. |
|
So unfortunately this PR won't do anything until we do that. CLosing for now. |
|
Ah, ok, well that explains my trouble getting it to work. From this thread, it sounded like if it compiled, clippy would be included in RLS. |
|
Clippy should be included from the next nightly |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #298.
By inspecting the vscode log files, I can confirm that it's receiving the setting properly, but I've yet to see any actual clippy lints when I have it set to "on."
Is there something else that needs to be done or am I just on a bad rls version?