Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak style of horizontal rules #1966

Merged
merged 1 commit into from
May 21, 2024
Merged

Tweak style of horizontal rules #1966

merged 1 commit into from
May 21, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented May 21, 2024

supersedes #1259

I started off making that one <hr/> tag white. Then I grepped for <hr to make sure everything is consistent. Three more such tags on the "Getting started" page were gray. I made them all white and added a vertical margin to make it it look more like a separator.

Lastly, I also noticed a really ugly <hr/> tag on the "Embedded devices" page. I replaced it with an appropriate margin.

Below all before-and-after screenshots, including small screen sizes for the embedded page.

Getting started page

location 1

location 2

location 3

location 4

Embedded devices page

large screen size

small screen size

@senekor senekor requested a review from a team as a code owner May 21, 2024 17:50
@Manishearth
Copy link
Member

merge when CI passes

@senekor senekor merged commit 0157fc9 into master May 21, 2024
2 checks passed
@senekor senekor deleted the remo/pnusrwnrsovq branch May 21, 2024 18:02
@senekor senekor mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants